[FLINK-6211] [kinesis] Validation error in Kinesis Consumer when using AT_TIMESTAMP as start position #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TAMP as start position
3 tasks
|
LGTM, thanks a lot for the fix and tests @tony810430! Merging this to |
p16i
pushed a commit
to p16i/flink
that referenced
this pull request
Apr 16, 2017
…nesisConsumer This closes apache#3636. This closes apache#3637.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the bug in validation function to check if the date string is well formed when using AT_TIMESTAMP as start position.
This function needs to check if one of the two conditions is passed, but I made a mistake to check all conditions should be passed. That causes the problem.