[FLINK-1484] Adds explicit disconnect message for TaskManagers #368
Conversation
| // disconnect the registered task managers | ||
| instanceManager.getAllRegisteredInstances.asScala.foreach{ | ||
| _.getTaskManager ! Disconnected("JobManager is stopping")} | ||
|
|
||
| for((e,_) <- currentJobs.values){ | ||
| e.fail(new Exception("The JobManager is shutting down.")) |
There was a problem hiding this comment.
Since we are cleaning up messages, maybe remove "The" so it is consistent with other messages.
There was a problem hiding this comment.
Thanks Henry for spotting it. I corrected it.
|
+1 LGTM |
|
Looks good. Since this is a behavior change, can you file a ticket for this, Till? |
|
My bad, there is a ticket already. Can you squash the commits then and add the ticket tag? Otherwise, good to merge! |
|
Yes, I'll do it. On Mon, Feb 9, 2015 at 10:23 AM, Stephan Ewen notifications@github.com
|
tillrohrmann
force-pushed
the
akkaSupervision
branch
4 times, most recently
from
1febbf4
to
3ff3a8b
Compare
…anagers that the JobManager has failed Fixes TestingTaskManager to detect disconnection of JobManager Fixes race condition when restarting actors in JobManagerFailsITCase Improves comment message Removes test listeners once the test message has been sent Fixes InvalidActorNameException in JobManagerFailsITCase when restarting the JobManager
tillrohrmann
force-pushed
the
akkaSupervision
branch
from
3ff3a8b
to
b8e38cb
Compare
|
@tillrohrmann and @StephanEwen worked on some other reliablity issues. Will the changes in this PR be subsumed by the upcoming changes? If not, we should merge this. :-) |
|
This PR has been merged as part of PR #423 |
In case of a JobManager restart, which can be caused by an uncaught exception, all connected TaskManager are notified by a
Disconnectedmessage. This message triggers the cleanup of the TaskManagers and makes them try to reconnect to the JobManager.This PR also includes a test case to verify the afore-mentioned behaviour.