[FLINK-6177] Add support for "Distributed Cache" in streaming applica… #3741
Conversation
|
Thanks for contributing this, the added functionality looks good. I would prefer to add this change without changing the dependencies and test base classes. You could for example change the test to throw an exception in the "validator function" if the word is not in the cache file. That way you do not need to "collect back" the data. Minor comment: Generating the input from a collection rather than a file makes the tests usually a bit more lightweight. In all newer tests, we try to do that. |
|
No problem. Will follow it and will create a new pull request. |
|
@zohar-pm You don't have to open a new one, feel free to update the branch in this one. |
|
Looks quite good now. If I can ask you for one more followup: To have faster tests, it would be good to add the streaming distributed cache test and the batch distributed cache test to the same file. Can you change the |
…d inherit from StreamingMultipleProgramsTestBase
| * @param filePath The path of the file, as a URI (e.g. "file:///some/path" or "hdfs://host:port/and/path") | ||
| * @param name The name under which the file is registered. | ||
| */ | ||
| public void registerCachedFile(String filePath, String name){ |
| * @param name The name under which the file is registered. | ||
| * @param executable flag indicating whether the file should be executable | ||
| */ | ||
| public void registerCachedFile(String filePath, String name, boolean executable){ |
|
merging. will add the missing space while I'm doing it. |
…tions This closes apache#3741.
…tions This closes apache#3741.
…tions This closes apache#3741.
…tions This closes apache#3741.
…tions
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed