[FLINK-5476] Fail fast if trying to submit a job to a non-existing Fl… #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmytroShkvyra
force-pushed
the
FLINK-5476
branch
from
e6ca9d1
to
5821f90
Compare
|
The code does not seem to match the PR description @DmytroShkvyra. I don't see where you use different timeouts for the connection. The only thing which seems to be modified is that the |
|
Hi @tillrohrmann, |
|
Hi @tillrohrmann could you review this PR |
|
Sorry for not coming back to you earlier. I will try to give it another round of review in the next days. |
DmytroShkvyra
force-pushed
the
FLINK-5476
branch
3 times, most recently
from
e6bcbba
to
d00ba9f
Compare
|
Was closed occasionally. |
|
New PR is #4001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of entering the wrong job manager address when submitting a job via flink run, the JobClientActor waits per default 60 s until a JobClientActorConnectionException, indicating that the JobManager is no longer reachable, is thrown. In order to fail fast in case of wrong connection information, we could change it such that it uses initially a much lower timeout and only increases the timeout if it had at least once successfully connected to a JobManager before.
General
Documentation
Tests & Build