Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6351] [YARN] Refactoring YarnFlinkApplicationMasterRunner by c… #3755

Closed
wants to merge 1 commit into from

Conversation

rice668
Copy link

@rice668 rice668 commented Apr 22, 2017

…ombining AbstractYarnFlinkApplicationMasterRunner in one class.

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

…ombining AbstractYarnFlinkApplicationMasterRunner in one class.
@rice668
Copy link
Author

rice668 commented Apr 24, 2017

cc @tillrohrmann

@shuai-xu
Copy link
Contributor

There will soon be a YarnFlinkAppMaster extends AbstractYarnFlinkApplicationMasterRunner for flink yarn cluster mode, so need not combine them to one class.

@rice668
Copy link
Author

rice668 commented May 26, 2017

Hey, @shuai-xu. Is there a corresponding JIRA for what you said ?

@tillrohrmann
Copy link
Contributor

No longer valid because of the changes of Flip-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants