Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-5752] [table] Support push down projections for HBaseTableSource (Ram) #3760

Closed
wants to merge 1 commit into from
Closed

Conversation

ramkrish86
Copy link
Contributor

@ramkrish86 ramkrish86 commented Apr 24, 2017

Ran mvn clean verify -DskipTests
In this patch
Arrays.sort(nestedFields[i]);

Am doing this before doing addColumns for the new projected table source, because here the cols appears in a reverse sorted way and when we apply that for the new projected table source it creates an assertion error while creating the new calcite program with the projected cols
assert expr.getType().getFieldList().get(field.getIndex()) == field;
{edit} the above line is in RexFieldAccess
So doing this sort helps in correcting those issues and the tests run fine. But this nestedFields that is being passed to the projectNestedFields() API is created by
def getProjectedFields: Array[Array[String]] under RexProgramExtractor. Trying to understand what it does.

@ramkrish86
Copy link
Contributor Author

@fhueske , @tonycox
Can you have a look at this PR? Thanks.

@ramkrish86
Copy link
Contributor Author

The failures seems not directly related.

@tonycox
Copy link
Contributor

tonycox commented Apr 25, 2017

@ramkrish86 Hi, Thank you for the PR. Could you repush commit?

git commit --amend
gut push origin FLINK-5752 -f

@ramkrish86
Copy link
Contributor Author

@tonycox
Thanks for the comment? Just curious. Any reason for the repush - is it for checking the test failures again?

@ramkrish86
Copy link
Contributor Author

I checked the recent failure.
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.417 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.JobManagerRegistrationTest

This failure seems unrelated with the changes in this patch.
@tonycox , @fhueske
Just a gentle ping.

@fhueske
Copy link
Contributor

fhueske commented Apr 27, 2017

Hi @ramkrish86,
I'm currently very busy getting the last changes for some bigger features in before the feature freeze for Flink 1.3. Can't promise that I'll have time to look at this before the release branch is forked off.

Best, Fabian

@ramkrish86
Copy link
Contributor Author

@fhueske
Thanks for the update. Got it.
But I would like to say that if there any issues/JIRA that I could be of help for the 1.3 release fork, I would happy to help. Pls point me to those you think I can be of help, I can have a look and commit to what ever I can spend time on.

@ramkrish86
Copy link
Contributor Author

@fhueske
Do you have some time to check this now considering Flink - 1.3 release is out?

@twalthr twalthr changed the title FLINK-5752 Support push down projections for HBaseTableSource (Ram) [FLINK-5752] [table] Support push down projections for HBaseTableSource (Ram) Jul 31, 2018
@zentol zentol closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants