[FLINK-6393] [gelly] Add Evenly Graph Generator to Flink Gelly #3788
Conversation
| /** | ||
| * Evenly graph means every {@link Vertex} in the {@link Graph} has the same degree. | ||
| * when vertex degree is 0, {@link EmptyGraph} will be generated. | ||
| * when vertex degree is vertex count - 1, {@link CompleteGraph} will be generated. |
There was a problem hiding this comment.
vertex count - 1 is confused. Can you change the description more clearly？
There was a problem hiding this comment.
vertex count - 1 means the degree of every vertex when evenly graph is complete graph, is this clear?
|
@fanzhidongyzby , thanks for the pr. Just a minor comment, mostly looks good to me. |
|
@fanzhidongyzby, what do you think about generalizing this to the |
|
@greghogan , I'm preparing to implement |
|
@fanzhidongyzby that sounds good except I would leave the Also, on the graph name, without a reference to the literature, perhaps this could be something invoking the idea that vertices are connected by length-1 paths to "far" vertices, by length-2 paths to "near" vertices, by length-3 paths to "far" vertices, etc. Something like |
The problem is that we don't wait until the JobManager becomes the leader. Due to this, the sent RegisterTaskManager messages might get dropped. This PR fixes the problem by waiting on the completion of the NotifyWhenLeader message.
And also the same bug in WindowOperatorMigrationTest
…lyGraph with CirculantGraph Generator
|
Hi, @greghogan , this pull request was closed unexpectedly by myself, please go to new pull request recreated. |
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passedEvenly graph means every vertex in the graph has the same degree, so the graph can be treated as evenly due to all the edges in the graph are distributed evenly. when vertex degree is 0, an empty graph will be generated. when vertex degree is vertex count - 1, complete graph will be generated.
The core idea is based on the concept of central symmetry. From the view of any vertex in the graph, the other vertices and edges are the same. So in the intermediate cases, edges are created from one vertex to the opposite vertex(if exists) and vertices on both sides of it.