Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6395] [tests] Mark test bases as abstract #3790

Closed
wants to merge 1 commit into from

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Apr 27, 2017

No description provided.

@tillrohrmann
Copy link
Contributor

Not sure whether marking classes without abstract methods abstract makes sense. If we want to prevent instantiations of these classes we could make the constructor also protected.

@zentol
Copy link
Contributor Author

zentol commented Apr 28, 2017

As you can see in the UnaryOperatorTestBase the constructors are already protected. The thing is that junit complains since the classes contain junit annotations (@After, @Parameterized, @RunWith) class but can't be instantiated. When i run these test in IntelliJ they are marked as failed tests due to an initialization error.

Making the classes abstract makes it clear they aren't actually self-contained test classes.

@tillrohrmann
Copy link
Contributor

Alright, now I understand. +1 for merging.

greghogan pushed a commit to greghogan/flink that referenced this pull request Apr 28, 2017
@asfgit asfgit closed this in d27d3dd Apr 29, 2017
@zentol zentol deleted the 6395_testbase_abstract branch May 2, 2017 13:56
fanyon pushed a commit to fanyon/flink that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants