New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup useless import for packages.scala ExternalCatalogTable arithm… #3795

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@sunjincheng121
Contributor

sunjincheng121 commented Apr 28, 2017

In this PR cleanup some useless reference in the following files:

  1. packages.scala
  2. ExternalCatalogTable
  3. arithmetic.scala
  4. array.scala
  5. ColumnStats
  • General

    • The pull request references the related JIRA issue ("[FLINK-6406][table] Cleanup useless import")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed
[FLINK-6406][table] Cleanup useless import for packages.scala Externa…
…lCatalogTable arithmetic.scala array.scala ColumnStats

greghogan added a commit to greghogan/flink that referenced this pull request Apr 28, 2017

@zentol

This comment has been minimized.

Show comment
Hide comment
@zentol

zentol Apr 29, 2017

Contributor

@aljoscha @tillrohrmann How come we don't have a scala checkstyle rule for unused imports?

Contributor

zentol commented Apr 29, 2017

@aljoscha @tillrohrmann How come we don't have a scala checkstyle rule for unused imports?

@asfgit asfgit closed this in ea54962 Apr 29, 2017

@greghogan

This comment has been minimized.

Show comment
Hide comment
@greghogan

greghogan Apr 29, 2017

Contributor

@zentol, doesn't look to be an option: scalastyle/scalastyle#193

Contributor

greghogan commented Apr 29, 2017

@zentol, doesn't look to be an option: scalastyle/scalastyle#193

fanyon pushed a commit to fanyon/flink that referenced this pull request May 11, 2017

hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment