[FLINK-6555] [futures] Generalize ConjunctFuture to return results #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
generalizeConjunctFuture
branch
from
a6fc20d
to
28bc0ac
Compare
StephanEwen
reviewed
May 11, 2017
There was a problem hiding this comment.
Good addition, with one comment about thread safety.
I was thinking that we could we make this two separate conjunct futures? One with result, one without? I like that the future used for scheduling (with possibly 1000s of tasks) is very lightweight (no list or anything).
| else if (numTotal == numCompleted.incrementAndGet()) { | ||
| complete(null); | ||
| } else { | ||
| results.add(o); |
There was a problem hiding this comment.
Is this thread safe? My assumption is that many of the completion handlers can be called at the same time.
There was a problem hiding this comment.
True, I wanted to use the numCompleted as the index but forgot about it. Thanks for catching it.
|
You're right with the thread safety. I will change it. I will introduce a |
tillrohrmann
force-pushed
the
generalizeConjunctFuture
branch
from
dc45e2b
to
f221353
Compare
|
Updated the PR to incorporate the PR review. Thanks for the review @StephanEwen. |
tillrohrmann
force-pushed
the
generalizeConjunctFuture
branch
from
f221353
to
ed46c26
Compare
The ConjunctFuture now returns the set of future values once it is completed.
…onjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>).
tillrohrmann
force-pushed
the
generalizeConjunctFuture
branch
from
ed46c26
to
b8de126
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
May 15, 2017
The ConjunctFuture now returns the set of future values once it is completed. Introduce WaitingConjunctFuture; Fix thread safety issue with ResultConjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>). This closes apache#3873.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
May 15, 2017
The ConjunctFuture now returns the set of future values once it is completed. Introduce WaitingConjunctFuture; Fix thread safety issue with ResultConjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>). This closes apache#3873.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
May 16, 2017
The ConjunctFuture now returns the set of future values once it is completed. Introduce WaitingConjunctFuture; Fix thread safety issue with ResultConjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>). This closes apache#3873.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
May 16, 2017
The ConjunctFuture now returns the set of future values once it is completed. Introduce WaitingConjunctFuture; Fix thread safety issue with ResultConjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>). This closes apache#3873.
asfgit
pushed a commit
that referenced
this pull request
May 17, 2017
The ConjunctFuture now returns the set of future values once it is completed. Introduce WaitingConjunctFuture; Fix thread safety issue with ResultConjunctFuture The WaitingConjunctFuture waits for the completion of its futures. The future values are discarded making it more efficient than the ResultConjunctFuture which returns the futures' values. The WaitingConjunctFuture is instantiated via FutureUtils.waitForAll(Collection<Future>). This closes #3873.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConjunctFuture now returns the set of values of the individual futures it is composed of once it is completed.