Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6569] flink-table KafkaJsonTableSource example doesn't work. #3890

Closed
wants to merge 1 commit into from

Conversation

haohui
Copy link

@haohui haohui commented May 12, 2017

This PR makes the proposed changes on the document and changes the Java unit tests to reflect the suggested usages of the API.

@rmetzger
Copy link
Contributor

Thank you for addressing this so quickly.
+1 from my side.

@twalthr
Copy link
Contributor

twalthr commented May 15, 2017

-1
@haohui The examples are correct if you use Types class of the Table API: org.apache.flink.table.api.Types

@haohui
Copy link
Author

haohui commented May 15, 2017

My understanding is that the snippet should only depend on the Java version of the API (ROW_NAMED in flink-core) instead of the one written in Scala that resides in flink-table. Correct?

@twalthr
Copy link
Contributor

twalthr commented May 16, 2017

The Java version of the API also depends on the Scala classes of flink-table. Everything in org.apache.flink.table.api is used in both languages. org.apache.flink.table.api.scala/java contain language specific classes.

@twalthr
Copy link
Contributor

twalthr commented May 24, 2017

@haohui can you close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants