Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6597][streaming] Cleanup WindowOperatorTest useless imports #3920

Closed
wants to merge 1 commit into from

Conversation

sunjincheng121
Copy link
Member

Don't miss doing any good thing no matter how insignificant it looks.

  • General

    • The pull request references the related JIRA issue ("[FLINK-6597][streaming] Cleanup WindowOperatorTest useless imports")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@fhueske
Copy link
Contributor

fhueske commented May 16, 2017

+1 to merge

@greghogan
Copy link
Contributor

@sunjincheng121 thanks for this PR. @fhueske what do you think of enabling checkstyle's includeTestSourceDirectory?

@greghogan
Copy link
Contributor

Perhaps we should enable checkstyle on test sources when upgrading to the strict checkstyle.

@fhueske
Copy link
Contributor

fhueske commented May 16, 2017

@greghogan that would make sense to me. Not sure why we excluded the tests in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants