[FLINK-5488] stop YarnClient before exception is thrown #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
reviewed
May 31, 2017
| @@ -392,6 +392,7 @@ protected YarnClient getYarnClient() { | |||
| @Override | |||
| public YarnClusterClient retrieve(String applicationID) { | |||
|
|
|||
| final YarnClient yarnClient = getYarnClient(); | |||
| try { | |||
| // check if required Hadoop environment variables are set. If not, warn user | |||
| if (System.getenv("HADOOP_CONF_DIR") == null && | |||
There was a problem hiding this comment.
does getYarnClient() fail if this condition is fulfilled? If so we should put this if block before the call to getYarnClient().
There was a problem hiding this comment.
It's a good point, I will put getYarnClient() in the try block
zentol
reviewed
Jun 19, 2017
| @@ -420,6 +421,9 @@ public YarnClusterClient retrieve(String applicationID) { | |||
|
|
|||
| return createYarnClusterClient(this, yarnClient, appReport, flinkConfiguration, false); | |||
| } catch (Exception e) { | |||
| if(null != yarnClient) { | |||
| @@ -146,7 +146,9 @@ public ApplicationStatus getApplicationStatus() { | |||
|
|
|||
| @Override | |||
| public void finalizeCluster() { | |||
| // Do nothing | |||
There was a problem hiding this comment.
Please revert the changes here. This file is part of another big initiative (referred to as FLIP-6); we shouldn't touch it unless necessary. (basically, I don't know about the yarn-client life-cycle here so let's be conservative.)
There was a problem hiding this comment.
I have reverted the changes and fixed another problem as Ted Yu metioned in FLINK-5488, thanks @zentol
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 26, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 27, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 27, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 28, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 29, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed