[FLINK-1555] Add serializer hierarchy debug util #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private static <T> String getSerializerTree(TypeInformation<T> ti, int indent) { | ||
| String ret = ""; | ||
| if(ti instanceof CompositeType) { | ||
| ret += ti.toString()+"\n"; |
There was a problem hiding this comment.
Should the toString method not already print the whole tree? Thus, the information would be redundant.
There was a problem hiding this comment.
I agree.
I'll also update the PR to list the field types of GenericTypes as well.
|
I've updated the PR to also print out the fields of GenericTypes. I'm thinking to merge this in the next 24 hours. |
|
I suggest putting this code into a Util, not inside the GenericTypeInfo. Also, CompositeType has a method getFields() that gives you the names of all fields. To be fair, I added this very recently. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.