Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7173][doc]Change the illustration of tumbling window. #4322

Closed
wants to merge 2 commits into from

Conversation

sunjincheng121
Copy link
Member

Change the illustration of tumbling window.

  • General

    • The pull request references the related JIRA issue ("[FLINK-7173][doc]Change the illustration of tumbling window.")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@sunjincheng121 sunjincheng121 force-pushed the FLINK-7173-PR branch 2 times, most recently from ca05339 to 9aa5b84 Compare July 13, 2017 12:19
@aljoscha
Copy link
Contributor

While on this, I think it would also make sense to fix the picture for sliding windows, what do you think?

@sunjincheng121
Copy link
Member Author

Yes @aljoscha I agree with you. I have updated the PR. -:)

Thanks, Jincheng

@aljoscha
Copy link
Contributor

@sunjincheng121 Thanks a lot! I merged, could you please close this PR?

@sunjincheng121 sunjincheng121 deleted the FLINK-7173-PR branch July 14, 2017 01:42
@sunjincheng121
Copy link
Member Author

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants