[FLINK-7331] [futures] Replace Flink's Future with Java 8's CompletableFuture in ResourceManager #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2017
Closed
zentol
reviewed
Aug 1, 2017
|
|
||
| final WorkerType newWorker = workerStarted(taskExecutorResourceId); | ||
|
|
||
| if(newWorker == null) { |
There was a problem hiding this comment.
Good catch. Will fix it.
| @@ -401,74 +354,37 @@ public RegistrationResponse apply(RegistrationResponse registrationResponse, Thr | |||
| * @return The response by the ResourceManager. | |||
| */ | |||
| @RpcMethod | |||
| public Future<RegistrationResponse> registerTaskExecutor( | |||
There was a problem hiding this comment.
Unintended renaming? This method is annotated with @RcpMethod, we need to change ResourceManagerGateway as well. Although this begs the question why we expose an internal method in the first place.
tillrohrmann
force-pushed
the
rfResourceManager
branch
from
14ec0af
to
2b24a7d
Compare
…leFuture in ResourceManager Address PR comments This closes apache#4444.
tillrohrmann
force-pushed
the
rfResourceManager
branch
from
65abab5
to
7f9d3da
Compare
|
Thanks for the review @zentol. I addressed your comments. Merging this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace Flink's Future with Java 8's CompletableFuture in ResourceManager.
This PR is based on #4443.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation