New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-7251] Merge the flink-java8 project into corresponding flink project #4455
Conversation
This would be easier to review (and for git to keep track of) if the individual commits would actually move a file, and not just copy them. |
@zentol Thank you for your suggestion, it sounds good to me and I have fixed them, thanks |
There's a compilation failure in flink-tests:
|
The StateBackendITCase can be resolved by bumping the tycho compiler version to 1.0.0, but the scala one remains. |
Could you check what happens when you remove the tycho-compiler completely? |
The |
Maybe it's better to move *ITCase to |
Are you talking about things like |
…tateBackendITCase
@zentol What do you think? Thanks :) |
We will have to revert every change that requires the tycho plugin to be moved into any other module. Using a different for these modules may have performance impacts and possibly subtle bugs. Sorry that i didn't notice it earlier. |
@zentol Thank you for your reply, and I agree with you that the risk will be a little high for this PR. I'd like to close this PR if there's no better solution, thanks |
What is the purpose of the change
Merge the codes in flink-java8 project into corresponding flink project
Brief change log
Verifying this change
(Please pick either of the following options)
This changes are examples and test cases without any test coverage
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation