[FLINK-7409] [web] Make WebRuntimeMonitor reactive #4527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
e9ea806
to
364b77b
Compare
|
@tillrohrmann please rebase now that #4492 has been merged |
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
364b77b
to
43b6686
Compare
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
43b6686
to
ea09d2a
Compare
|
Done @greghogan. |
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
ea09d2a
to
fcb0d15
Compare
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
fcb0d15
to
c41a8e4
Compare
|
Failing test cases are unrelated. Merging this PR. |
This commit changes the behaviour of the WebRuntimeMonitor to not longer block serving threads by waiting on the result of futures. Instead the RequestHandler now returns a CompletableFuture<FullHttpResponse> which is written out to the Netty channel upon completion. This will improve the performance of our WebRuntimeMonitor. This closes apache#4527.
tillrohrmann
force-pushed
the
reactiveMonitor
branch
from
c41a8e4
to
44facda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit changes the behaviour of the WebRuntimeMonitor to not longer block serving
threads by waiting on the result of futures. Instead the RequestHandler now returns a
CompletableFuture which is written out to the Netty channel upon
completion. This will improve the performance of our WebRuntimeMonitor.
This PR is based #4492.
Brief change log
RequestHandler#handleRequestVerifying this change
This change is already covered by existing tests, such as the tests contained in
flink-runtime-web.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation