[FLINK-7474] [ Streaming Connectors] AzureEventhubs-connector, support read from and write to Azure eventhubs #4535
Conversation
The fact that we always returned URL objects is a relic of the BlobServer's only use for URLClassLoader. Since we'd like to extend its use, returning File objects instead is more generic. This closes apache#4236.
|
Hi @zhuganghuaonnet, thanks a lot for this contribution! |
[FLINK-7056][blob] refactor the new API for job-related BLOBs For a cleaner API, instead of having a nullable jobId parameter, use two methods: one for job-related BLOBs, another for job-unrelated ones. This closes apache#4237.
Since the generated project is an sbt project, it is much more straightfoward for the user to create it with the new "sbt new" command than by using giter8 (which requires to install giter8 just for that purpose). This closes apache#4531.
The TestingSerialRpcService produces thread interleavings which are not happening when being executed with a proper RpcService implementation. Due to this the test cases can fail or succeed wrongly. In order to avoid this problem, this commit removes the TestingSerialRpcService and adapts all existing tests which used it before. Remove TestingSerialRpcService from MesosResourceManagerTest Remove TestingSerialRpcService from ResourceManagerJobMasterTest Remove TestingSerialRpcService from ResourceManagerTaskExecutorTest Remove TestingSerialRpcService from ResourceManagerTest Remove SerialTestingRpcService from JobMasterTest Remove TestingSerialRpcService from TaskExecutorITCase Remove TestingSerialRpcService from TaskExecutorTest Remove TestingSerialRpcService from SlotPoolTest Delete TestingSerialRpcService This closes apache#4516.
|
Hi Tai,
I cannot find JIRA related to Azure eventhubs. I will create one later, fill pull request template and send another pull request. Thx.
Regards
Joe
…________________________________
From: Tzu-Li Tai <notifications@github.com>
Sent: Monday, August 14, 2017 3:48:53 PM
To: apache/flink
Cc: zhuganghuaonnet; Mention
Subject: Re: [apache/flink] Eventhubs-support read from and write to Azure eventhubs (#4535)
Hi @zhuganghuaonnet<https://github.com/zhuganghuaonnet>, thanks a lot for this contribution!
However, taking a step back, is there a JIRA ticket for this contribution?
If not, please make sure that one is opened for it first. Also, for bigger contributions like this, you should make sure that the pull request template is properly filled out to ease the effort for reviewers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4535 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/APWS44gqqy5hT02uGV1Mlb2gSdRRCBEYks5sX_vkgaJpZM4O18go>.
|
… Table API and SQL This closes apache#4538.
|
@zhuganghuaonnet we should also mention that new connectors are being contributed through the Flink release of Apache Bahir. |
…w final This closes apache#4539.
userDefinedOffset.toLowerCase() == "lastest" does not work in JAVA world
Previously if localPort was set 0, actually obtained/bind port was not logged anywhere. Now we print local port after binding.
|
@greghogan I don't think there's actually a consensus that all new connectors should strictly go to Apache Bahir. It still depends case by case, and brought to discussion in the mailing lists if necessary. We have a growing base of Azure users, and I think it would be nice to have better Azure support. Having a connector for their mainly used event source would be a nice addition, IMO. What do you think? |
…ttpReporter This closes apache#4508.
…Case This helps tease out races, for example the recently discovered one in cleanup of incremental state handles at the SharedStateRegistry. (cherry picked from commit d7683cc)
…ization of CheckpointProperties
|
@tzulitai this does sound like a good candidate for inclusion in Flink. Perhaps a separate |
|
@greghogan yes, a separate |
|
@zhuganghuaonnet please let me know when you've opened the JIRA, and rebased this pull request onto the latest Thanks a lot! |
…on schema in FlinkKinesisConsumer This commit also adds tests for verifying that the FlinkKinesisConsumer itself is serializable.
…oner is serializable in FlinkKinesisProducer This commit also adds a test to verify that the FlinkKinesisProducer is serializable. This closes apache#4537.
- Improve deprecation message in Javadocs - Remove usage of ProducerConfigConstants in code wherever possible - Remove usage of ProducerConfigConstants in documentation code snippets This closes apache#4473.
|
@zhuganghuaonnet it doesn't seem like the PR is correctly rebased. Ideally, you should rebase your development branch to the latest master, and the PR only contains for your changes, and not others. And yes, please include necessary unit tests / integration tests along with the PR! |
…into eventhubs # Conflicts: # pom.xml
…t read from and write to Azure eventhubs
…into eventhubs # Conflicts: # flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
…ing on windows platform
…into eventhubs
…tatus and waiting forevet if eventhubproducerthread quit
|
Hi @zhuganghuaonnet , you should drop others commits and squash your commits. |
Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.
Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.
Contribution Checklist
Make sure that the pull request corresponds to a JIRA issue. Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
Name the pull request in the form "[FLINK-1234] [component] Title of the pull request", where FLINK-1234 should be replaced by the actual issue number. Skip component if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern:
[hotfix] [docs] Fix typo in event time introductionor[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator.Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
Make sure that the change passes the automated tests, i.e.,
mvn clean verifypasses. You can set up Travis CI to do that following this guide.Each pull request should address only one issue, not mix up code from multiple issues.
Each commit in the pull request has a meaningful commit message (including the JIRA id)
Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation