[FLINK-4831][metrics] Implement a slf4j metric reporter #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice that you figured out to rename the package to slf4j :) I'll check this out in more detail next week. |
yew1eb
changed the title
|
@zentol Please let me know if this is good :) |
|
CC @zentol |
zentol
reviewed
Oct 24, 2017
| for (int i = 0; i < strLen; i++) { | ||
| final char c = input.charAt(i); | ||
| switch (c) { | ||
| case ':': |
There was a problem hiding this comment.
why are we filtering this character?
| /** | ||
| * Test for {@link Slf4jReporter}. | ||
| */ | ||
|
|
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-runtime_${scala.binary.version}</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>provided</scope> |
There was a problem hiding this comment.
move to test dependency block and set scope to test
|
|
||
| <dependency> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-test-utils-junit</artifactId> |
| # limitations under the License. | ||
| # | ||
|
|
||
| log4j.rootLogger=INFO, testlogger |
There was a problem hiding this comment.
This will cause a bit of noise in the logs that I would like to avoid.
Instead, can we, If the log level is configured to OFF, remove all other appenders and set it to INFO? This will make the test run without affecting log files etc.
|
@zentol thanks a lot for your review. I have updated the PR according to your comments. |
|
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Implement a slf4j metric reporter For debugging.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation