[FLINK-6549] [DataStream API] Improve error message for type mismatches with side outputs #4663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good. |
|
Hi @zentol , let me know if you can help merge this in :) |
|
LGTM |
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Sep 18, 2017
…ith side outputs This closes apache#4663.
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Sep 19, 2017
…ith side outputs This closes apache#4663.
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2017
…ith side outputs This closes #4663.
Johnlon
reviewed
Sep 23, 2019
| "but identical names are being used.", | ||
| e.getMessage(), outputTag.getId())); | ||
|
|
||
| throw new ExceptionInChainedOperatorException(replace); |
There was a problem hiding this comment.
Swallows the original exception which is never a good thing for someone trying to diagnose a problem like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A type mismatch when using side outputs causes a ClassCastException to be thrown. It would be neat to include the name of the
OutputTags in the exception message.This can occur when multiple
OutputTags with different types but identical names are being used.Brief change log
With this change, ClassCastException will be caught separately. We will replace it with a new one that has enriched error message. The enriched error message will have
OutputTag's id, and a brief explanation of why this error may occur.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
The new error message looks like this:
Does this pull request potentially affect one of the following parts:
Documentation