[FLINK-7661][network] Add credit field in PartitionRequest message #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijiangW
force-pushed
the
FLINK-7661
branch
2 times, most recently
from
1765f70
to
feef05e
Compare
NicoK
approved these changes
Sep 27, 2017
|
Actually, what worries me a bit are the test failures of the 3rd and 4th test profile. I think, they're unrelated (especially the Kafka ones which are kind of instable at the moment in general), but the other ones look strange. Can you let them re-run to see if this is consistent? |
|
@NicoK , thanks for your reviews! I checked the travis failure before and thought it should be existing flaky ones. I will re-trigger the tests later and see the results. |
zhijiangW
force-pushed
the
FLINK-7661
branch
2 times, most recently
from
1e3e9eb
to
5665a85
Compare
|
@NicoK , it already passed travis tests this time. |
|
ok, cool, then we can merge this PR as anticipated |
zhijiangW
force-pushed
the
FLINK-7661
branch
2 times, most recently
from
8dc3799
to
d32430c
Compare
|
@zentol , I have rebased the latest master codes and solved the conflicts. |
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Oct 11, 2017
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Oct 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
PartitionRequestmessage adds the credit field which corresponds to the number of exclusive segments inInputChannel.This pull request is based on 4499.
Brief change log
PartitionRequestmessagegetInitialCredit()method inRemoteInputChannelVerifying this change
This change is already covered by existing tests, such as NettyMessageSerializationTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation