Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-3832][build][WIP] POM Cleanup flink-streaming-scala #4718

Closed
wants to merge 1 commit into from

Conversation

yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Sep 24, 2017

What is the purpose of the change

This PR changes the flink-streaming-scala pom to

  • not contain unused dependencies
  • contain all used dependencies

Brief change log

Verifying this change

mvn dependency:analyze

[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-streaming-scala_2.11 ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.apache.flink:flink-core:jar:1.4-SNAPSHOT:compile
[WARNING]    com.esotericsoftware.kryo:kryo:jar:2.24.0:compile
[WARNING]    org.apache.flink:flink-test-utils-junit:jar:1.4-SNAPSHOT:test
[WARNING]    org.apache.flink:flink-annotations:jar:1.4-SNAPSHOT:compile
[WARNING]    org.apache.flink:flink-runtime_2.11:jar:1.4-SNAPSHOT:compile
[WARNING]    org.apache.flink:flink-java:jar:1.4-SNAPSHOT:compile
[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING]    com.google.code.findbugs:jsr305:jar:1.3.9:compile
[WARNING]    log4j:log4j:jar:1.2.17:test
[WARNING]    org.powermock:powermock-api-mockito:jar:1.6.5:test
[WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test
[WARNING]    org.scala-lang:scala-compiler:jar:2.11.11:compile
[WARNING]    org.powermock:powermock-module-junit4:jar:1.6.5:test
[WARNING]    org.mockito:mockito-all:jar:1.10.19:test
[WARNING]    org.scala-lang:scala-reflect:jar:2.11.11:compile
[WARNING]    org.slf4j:slf4j-api:jar:1.7.7:compile
[WARNING]    org.apache.flink:flink-runtime_2.11:test-jar:tests:1.4-SNAPSHOT:test

After the change:

[INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @ flink-streaming-scala_2.11 ---
[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest-all:jar:1.3:test
[WARNING]    org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
[WARNING]    org.powermock:powermock-module-junit4:jar:1.6.5:test
[WARNING]    com.google.code.findbugs:jsr305:jar:1.3.9:compile
[WARNING]    log4j:log4j:jar:1.2.17:test
[WARNING]    org.mockito:mockito-all:jar:1.10.19:test
[WARNING]    org.powermock:powermock-api-mockito:jar:1.6.5:test
[WARNING]    org.slf4j:slf4j-api:jar:1.7.7:compile
[WARNING]    org.slf4j:slf4j-log4j12:jar:1.7.7:test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)

Documentation

none

@yew1eb yew1eb changed the title [FLINK-3832][build] POM Cleanup flink-streaming-scala [FLINK-3832][build][WIP] POM Cleanup flink-streaming-scala Sep 28, 2017
@zentol
Copy link
Contributor

zentol commented Mar 1, 2019

We will have to redo this from scratch since too much time has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants