[FLINK-7667] [flip6] Use ArchivedExecutionGraph as serializable AccessExecutionGraph #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
requested changes
Sep 26, 2017
| import java.io.Serializable; | ||
| import java.util.Objects; | ||
|
|
||
| public class JobCheckpointingConfiguration implements Serializable { |
There was a problem hiding this comment.
missing javadoc. Can we also find a better name, since "Settings" and "Configuration" are virtually interchangeable? (Like CHeckpointCoordinatorConfig?)
There was a problem hiding this comment.
Thanks for pointing this out. I will add it and think about a better name.
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
2 times, most recently
from
81d51c8
to
325105e
Compare
|
I've addressed your comments @zentol. The PR should now build and I renamed |
|
+1. |
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
from
325105e
to
7a8db98
Compare
|
Thanks for the review @zentol. Rebasing this commit and waiting on Travis. |
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
from
7a8db98
to
0d2343a
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 27, 2017
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 27, 2017
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
from
0d2343a
to
0333de3
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 27, 2017
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
from
0333de3
to
6edb015
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 27, 2017
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
tillrohrmann
force-pushed
the
serializableAccessExecutionGraph
branch
from
6edb015
to
2dd557f
Compare
|
Merging this PR. |
yew1eb
pushed a commit
to yew1eb/flink
that referenced
this pull request
Oct 4, 2017
…sExecutionGraph This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration. The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant configuration settings and excludes the serialized state backend and the serialized master hooks. That way we don't send unnecessary information when the ArchivedExecutionGraph is requested. This closes apache#4727.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit removes AccessExecutionGraph#getCheckpointCoordinator and changes the
AccessExecutionGraph#getJobCheckpointSettings into #getJobCheckpointConfiguration.
The JobCheckpointConfiguration only contains the CheckpointCoordinator relevant
configuration settings and excludes the serialized state backend and the
serialized master hooks. That way we don't send unnecessary information when
the ArchivedExecutionGraph is requested.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation