[FLINK-7371] [table] Add support for constant parameters in OVER aggregate #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
Oct 2, 2017
|
|
||
| val field = | ||
| s""" | ||
| |transient $boxedType $fieldTerm; |
There was a problem hiding this comment.
why transient? Couldn't this be final?
| .window( | ||
| Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as 'w) | ||
| .select('c, weightAvgFun('a, 42, 'b, "2") over 'w as 'wAvg) | ||
| .select('c, 'wAvg) |
| @@ -86,6 +86,13 @@ public Long getValue(WeightedAvgAccum accumulator) { | |||
| } | |||
|
|
|||
| // overloaded accumulate method | |||
| // dummy to test constants | |||
| public void accumulate(WeightedAvgAccum accumulator, long iValue, int iWeight, int x, String string) { | |||
| accumulator.sum += iWeight + Integer.parseInt(string); | |||
There was a problem hiding this comment.
change the method to
accumulator.sum += (iValue + Integer.parseInt(string)) * iWeight;
accumulator.count += iWeight;
to have some influence of the value of string in the result?
|
Thanks @fhueske. I addressed you feedback. Will merge this now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR allows to pass constants to OVER window aggregates. E.g.
.select('c, weightAvgFun('a, 42, 'b, "2") over 'w as 'wAvg).Brief change log
Until now the constants where simply ignored. I added code generation for the literals in
AggregationCodeGenerator.Verifying this change
I add a ITCase for it. I might add more tests if I have time. In general, we need to rework the logic there a little bit, because I think we also do not support DATE, TIME etc. right now.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation