Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7727] [REST] Improve error logging in StaticFileServerHandlers #4743

Closed
wants to merge 1 commit into from

Conversation

zentol
Copy link
Contributor

@zentol zentol commented Sep 28, 2017

What is the purpose of the change

This PR improves the logging of errors in the StateFileServerHandlers

Brief change log

  • separate checks for file existence and path not pointing to a directory
  • pointing to a directory now returns 405 Method Not Allowed
  • pointing outside the root directory now returns 403 Forbidden
  • add a debug logging message to each check
  • re-order checks, so that we first check whether the path points into the root directory before checking if it exists, to not leak information about resources the user may not access

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

@tillrohrmann
Copy link
Contributor

Closing this PR because it is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants