Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-7818] Synchronize MetricStore access in TaskManagersHandler #4811

Closed
wants to merge 1 commit into from
Closed

[FLINK-7818] Synchronize MetricStore access in TaskManagersHandler #4811

wants to merge 1 commit into from

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

Synchronize MetricStore access in TaskManagersHandler

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

zentol
zentol approved these changes Oct 12, 2017
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. Merging this PR.

@asfgit asfgit closed this in 742e4a0 Oct 12, 2017
@tillrohrmann tillrohrmann deleted the fixTaskManagersHandler branch October 12, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentol zentol zentol approved these changes

Assignees
No one assigned
Labels
component=Runtime/Metrics component=Runtime/REST
Projects
None yet
Milestone
No milestone
3 participants
@tillrohrmann @zentol @rmetzger