[FLINK-8013] [table] Support aggregate functions with generic arrays #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
Nov 15, 2017
| import org.apache.flink.table.api.Types | ||
|
|
||
| /** | ||
| * User-defined aggregation function to compute the TOP 10 most visited pages. |
There was a problem hiding this comment.
Adjust the comment:
User-defined aggregation function to compute the top 10 Int IDs with the highest Float values.
We use an Array[Tuple2[Int, Float]] as accumulator to store the top 10 entries.
fhueske
reviewed
Nov 15, 2017
| @@ -55,7 +55,6 @@ object CollectionDataSets { | |||
| data.+=((19, 6L, "Comment#13")) | |||
| data.+=((20, 6L, "Comment#14")) | |||
| data.+=((21, 6L, "Comment#15")) | |||
| Random.shuffle(data) | |||
There was a problem hiding this comment.
I think this should be added back.
There was a problem hiding this comment.
No, the result of this shuffle is discarded. data is not modified.
fhueske
reviewed
Nov 15, 2017
| @@ -0,0 +1,107 @@ | |||
| package org.apache.flink.table.utils | |||
|
Merging this... |
asfgit
pushed a commit
that referenced
this pull request
Nov 15, 2017
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds supports for aggregate functions with generic arrays and fixes other bugs.
Brief change log
Verifying this change
Complex aggregation function added.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation