[FLINK-8113][build] Bump maven-shade-plugin to 3.0.0 #5042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Do we know if there are any new known issues in shade "3.0.0"? The first release of a new major version sometimes has a few regressions. Have you checked the Maven JIRA per chance? Otherwise +1 |
|
I looked through the open issues for 3.0.0, and the ones that were fixed for 3.1.0 and i couldn't find anything critical. |
|
merging, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR bumps the maven-shade-plugin version to 3.0.0.
Benefits:
Verifying this change
This change should be covered by travis and the end-to-end tests.