Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8142][config] Cleanup reference to deprecated constants in ConfigConstants #5067

Closed
wants to merge 1 commit into from

Conversation

yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Nov 24, 2017

What is the purpose of the change

ConfigConstants contains several deprecated String constants that are used by other Flink modules. Those should be cleaned up.

Brief change log

  • Replace usages of deprecated TASK_MANAGER_MEMORY_SIZE_KEY , EXECUTION_RETRIES_KEY, EXECUTION_RETRY_DELAY_KEY, TASK_MANAGER_MEMORY_PRE_ALLOCATE_KEY, JOB_MANAGER_IPC_ADDRESS_KEY

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@tzulitai tzulitai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

@greghogan
Copy link
Contributor

+1; merging ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants