[FLINK-8149][kinesis] Replace usages of deprecated SerializationSchema

[yew1eb]

What is the purpose of the change

The deprecated SerializationSchema in flink-streaming-java, has been moved to flink-core.
replace usages of deprecated SerializationSchema in flink-connector-kinesis.

Brief change log

• Replace usages of DeserializationSchema, SerializationSchema, SimpleStringSchema

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)
• If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[tzulitai]

I think we can not simply remove the usage of this, as that will be an user API-breaking change (for users that use the FlinkKinesisConsumer(String, DeserializationSchema<T>, Properties) constructor).

Instead of removing this, we should deprecate the constructors that accept the deprecated DeserializationSchema interface, and add new corresponding constructors that accept the new migrated DeserializationSchema.

[yew1eb]

make sense.

[tzulitai]

Same here; see above coment.

[tzulitai]

Thanks for the PR @yew1eb! I have one comment regarding how the change breaks user API.

[yew1eb]

@tzulitai, thanks for your review. I have updated the PR according to your comments.

[tzulitai]

LGTM, merging this ..

[tzulitai]

Ah, I just realized that my comment on the last review is irrelevant, since org.apache.flink.streaming.util.serialization.SerializationSchema extends org.apache.flink.api.common.serialization.SerializationSchema, meaning that there is no API-breaking change.

Sorry about this. The PR is good to go without the extra follow-up fix. Merging the first commit.

[bowenli86]

I just saw the code in src tree and traced back to this PR. I feel it's really bad to have runnable examples (with java main method) in a lib jar that Flink distributes.

Can we move the examples to /test? I believe that's the right way of adding examples

[tzulitai]

@bowenli86 do you mean the ProduceIntoKinesis and ConsumeFromKinesis classes?
I agree that we should move them to /test, but we should consider that as a separate issue than this one. Could you open a JIRA for that?

[bowenli86]

My apologies! Silly mistake at late night when the brain is quite inactive.... I forgot to check the files history, and thought this PR (which shows as latest commit) added those examples...

Opened FLINK-8218. Sincere apologies again!