Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7984][build] Bump snappy-java to 1.1.4 #5072

Closed
wants to merge 1 commit into from

Conversation

yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Nov 26, 2017

What is the purpose of the change

This PR bumps the snappy-java version to 1.1.4.
snappy-java-1.1.4 (2017-05-22):

  • Fix a 1% performance regression when snappy is used in PIE executables.
  • Improve compression performance by 5%.
  • Improve decompression performance by 20%.
  • See more: Snappy-java Release Notes

Verifying this change

This change should be covered by travis and the end-to-end tests.

@greghogan
Copy link
Contributor

@yew1eb have you looked at FLINK-6965?

@yew1eb
Copy link
Contributor Author

yew1eb commented Dec 8, 2017

@greghogan, I saw the following in the flink-core POM:

<!-- We explicitly depend on snappy since connectors that require it load it through the system class loader -->
<dependency>
       <groupId>org.xerial.snappy</groupId>
       <artifactId>snappy-java</artifactId>
</dependency>

I think this PR just upgrades the snappy-java version from 1.1.1.3 to 1.1.4 for the "flink-core" module. I can not find out what bad effects it will cause.:)

@StephanEwen
Copy link
Contributor

Bumping the version should be fine. We only need to make sure that wherever this is pulled, we promote it to a direct dependency such that dependency convergence works.

@StephanEwen
Copy link
Contributor

Merging this...

@StephanEwen
Copy link
Contributor

Sorry, actually, taking a step back: Can you check in which dependencies snappy is included in addition?
Especially big packaged dependencies like flink-s3-fs-presto and flink-s3-fs-hadoop? In case they contain snappy, we should manage the dependency to the same version there. If two different versions get pulled in, the update may not have an effect.

@zentol
Copy link
Contributor

zentol commented Feb 5, 2018

@yew1eb Could you close the PR? The issue was addressed in f1e4d25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants