Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8171] [flip6] Remove work arounds from Flip6LocalStreamEnvironment #5101

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

It is no longer needed to wait for the registration of task managers and
to not use slot sharing when submitting jobs to the Flip-6 MiniCluster.
Therefore, we can remove these work arounds from the
Flip6LocalStreamEnvironment.

This PR is based on #5091.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zentol
Copy link
Contributor

zentol commented Nov 29, 2017

Can we also remove this bit

// temporary hack for FLIP-6 since slot-sharing isn't implemented yet
jobGraph.setAllowQueuedScheduling(true);

from the RestClusterClient?

@tillrohrmann
Copy link
Contributor Author

tillrohrmann commented Nov 29, 2017

I think we can remove the comment but not disabling the queued scheduling mode which is mandatory for Flip-6 to work. I'll remove the comment.

…ment

It is no longer needed to wait for the registration of task managers and
to not use slot sharing when submitting jobs to the Flip-6 MiniCluster.
Therefore, we can remove these work arounds from the
Flip6LocalStreamEnvironment.

Adapt comment in RestClusterClient

This closes apache#5101.
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @zentol. I've rebased this PR and once Travis gives green light, I'll merge it.

@asfgit asfgit merged commit 8e7a71c into apache:master Dec 31, 2017
@tillrohrmann tillrohrmann deleted the fixLocalStreamEnvironmentITCase branch December 31, 2017 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants