Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-1766]Fix the bug of equals function of FSKey #511

Closed
wants to merge 3 commits into from
Closed

[FLINK-1766]Fix the bug of equals function of FSKey #511

wants to merge 3 commits into from

Conversation

matadorhong
Copy link
Contributor

The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true

@StephanEwen
Copy link
Contributor

Looks good. This seems more like an optimization, than a bug,

Before we can merge the change, it needs to be brought in sync with the code style. Currently, the checkstyle rules reject the code for using spaces rather than tabs.

@StephanEwen
Copy link
Contributor

If you are interested: Here are some simple guidelines on how to format code and create easy to merge commits for pull requests:

http://flink.apache.org/coding_guidelines.html

@matadorhong
Copy link
Contributor Author

Great thanks to Ewen. I will first have a study of how to format code. Then pull a request.

@matadorhong
Copy link
Contributor Author

Thanks for Ewen. That help me a lot to understand how to contribute to Flink. I will follow the guide in the future.

@StephanEwen
Copy link
Contributor

No problem. We are happy that you are interested to contribute :-)

@matadorhong
Copy link
Contributor Author

@StephanEwen I have fixed the code style issue and changed the PR to an "Improvement" one in jira.
Finally, great thanks for your help. And I will take more time to contribute in Flink.

@hsaputra
Copy link
Contributor

LGTM. Will merge later today. Thanks!

@asfgit asfgit closed this in d8c74d2 Mar 31, 2015
bhatsachin pushed a commit to bhatsachin/flink that referenced this pull request May 5, 2015
@matadorhong @bhatsachin
[FLINK-1766]Fix the bug of equals function of FSKey
57e22c8 
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true

Author: hongsibao <hongsibao@huawei.com>

Closes apache#511 from matadorhong/Bug_Flink_1776 and squashes the following commits:

1ad06d7 [hongsibao] Fix the code format problem
431fc4b [hongsibao] Fix the code format problem
ab0ae5e [hongsibao] [FLINK-1766]Fix the bug of equals function of FSKey
marthavk pushed a commit to marthavk/flink that referenced this pull request Jun 9, 2015
@matadorhong @marthavk
[FLINK-1766]Fix the bug of equals function of FSKey
b9ce23f 
The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first confirm whether obj == this, if obj is the same object.It should return true

Author: hongsibao <hongsibao@huawei.com>

Closes apache#511 from matadorhong/Bug_Flink_1776 and squashes the following commits:

1ad06d7 [hongsibao] Fix the code format problem
431fc4b [hongsibao] Fix the code format problem
ab0ae5e [hongsibao] [FLINK-1766]Fix the bug of equals function of FSKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
4 participants
@matadorhong @StephanEwen @hsaputra @rmetzger