Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8224] [runtime] shutdown application when job terminated in job mode #5139

Closed
wants to merge 3 commits into from

Conversation

shuai-xu
Copy link
Contributor

@shuai-xu shuai-xu commented Dec 8, 2017

What is the purpose of the change

This current job cluster entrypoint doesn't call resource manage to shutdown the application. So resource manger has no change to set the application status to the outer resource management system such as YARN/Mesos. This may make the YARN still consider the application as running even the job is finished.

Verifying this change

This change is tested manually.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@pnowojski
Copy link
Contributor

If nobody else is currently reviewing this one, I can take a look into it this week.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @shuai-xu. Changes look good. Merging this PR.

tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Jan 25, 2018
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Jan 25, 2018
@asfgit asfgit closed this in a4ecc7f Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants