Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8292] Remove unnecessary force cast in DataStreamSource #5180

Closed
wants to merge 1 commit into from
Closed

[FLINK-8292] Remove unnecessary force cast in DataStreamSource #5180

wants to merge 1 commit into from

Conversation

Matrix42
Copy link
Contributor

@Matrix42 Matrix42 commented Dec 19, 2017

What is the purpose of the change

Remove unnecessary force cast in DataStreamSource

Verifying this change

This change is already covered by existing tests, such as DataStreamTest.testParallelism()

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@greghogan
Copy link
Contributor

+0

@Matrix42 Matrix42 closed this Jan 2, 2018
@zentol
Copy link
Contributor

zentol commented Jan 8, 2018

merging.

zentol pushed a commit to zentol/flink that referenced this pull request Jan 8, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Jan 8, 2018
@Matrix42 Matrix42 deleted the DataStreamSource branch February 28, 2018 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants