[FLINK-8324] [kafka] Expose another offsets metrics by using new metric API to specify user defined variables #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o specify user defined variables
|
Good idea. I think we should also update the metrics doc to educate this addition. |
|
@tzulitai Have updated the metrics doc. |
|
Thanks for the PR @tony810430. The changes LGTM, will merge this a bit later. |
tzulitai
added a commit
to tzulitai/flink
that referenced
this pull request
Jan 12, 2018
… should not be touched This commit consolidates all metrics related constant string names in a KafkaConsumerMetricConstants class, to give a better overview code-wise which metrics are exported. That makes it more clear in the code which metrics are kept for compatibility reasons. It also additionally states that metric names should not be changed, otherwise metrics compatibility will be broken. This closes apache#5214.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add two metrics for current offsets and committed offsets by using new metric API, which can define user scope variables.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation