Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-8348] [flip6] Print help for DefaultCLI #5233

Closed
wants to merge 7 commits into from
Closed

[FLINK-8348] [flip6] Print help for DefaultCLI #5233

wants to merge 7 commits into from

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

Print help for the DefaultCLI.

This PR is based on #5232.

Verifying this change

  • Trivial change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@tillrohrmann tillrohrmann mentioned this pull request Jan 2, 2018
Closed
@tillrohrmann tillrohrmann force-pushed the fixCustomCommandLineHelp branch 8 times, most recently from 72a0451 to 3d62696 Compare January 4, 2018 07:55
GJL
GJL approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@GJL GJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3d62696)

@tillrohrmann
[FLINK-8340] [flip6] Remove passing of Configuration to CustomCommand…
08a4788 
…Line

Since the Configuration does not change over the lifetime of a CustomCommandLine,
we can safely pass it as a constructor argument instead of method argument.

This closes apache#5226.
@tillrohrmann
[FLINK-8341] [flip6] Remove not needed options from CommandLineOptions
20bf4f1 
This closes apache#5227.
@tillrohrmann
[FLINK-8342] [flip6] Remove generic type parameter from ClusterDescri…
142c170 
…ptor

This closes apache#5228.
@tillrohrmann
[FLINK-8349] [flip6] Remove Yarn specific commands from YarnClusterDe…
59381f6 
…scriptor

Remove Yarn specific commands from YarnClusterDescriptor. This is a preparational
step to make the FlinkYarnSessionCli work with the Flip-6 RestClusterClient.

This closes apache#5229.
@tillrohrmann
[hotfix] Add help command to FlinkYarnSessionCli
fda1948
@tillrohrmann
[FLINK-8347] [flip6] Make cluster id used by ClusterDescriptor typesafe
ac34a61 
The ClusterDescriptor uses a typed cluster id for the ClusterClient retrieval.
Moreover, the ClusterClient and the CustomCommandLine are typed accordingly.

This closes apache#5232.
@tillrohrmann
[FLINK-8348] [flip6] Print help for DefaultCLI
ad69f50 
This closes apache#5233.
@tillrohrmann
Copy link
Contributor Author

Thanks for the review @GJL. Merging this PR once Travis gives green light.

@asfgit asfgit closed this in 7d986ce Jan 12, 2018
@tillrohrmann tillrohrmann deleted the fixCustomCommandLineHelp branch January 13, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GJL GJL GJL approved these changes

Assignees
No one assigned
Labels
component=CommandLineClient
Projects
None yet
Milestone
No milestone
3 participants
@tillrohrmann @GJL @rmetzger