[FLINK-8368] [REST] Migrate SubtaskExecutionAttemptDetailsHandler to new a REST handler #5270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2018 16:44
…taskExecutionAttemptDetailsHandler to new a REST handler that registered in WebMonitorEndpoint
…onAttemptDetailsHeaders
ifndef-SleePy
force-pushed
the
FLINK-8368
branch
from
a19c343
to
50eb6e7
Compare
tillrohrmann
approved these changes
Jan 14, 2018
There was a problem hiding this comment.
Thanks for your contribution @ifndef-SleePy. Changes look really good. Will merge this PR.
| } | ||
|
|
||
| return new JobVertexAccumulatorsInfo(jobVertex.getJobVertexId().toString(), userAccumulatorList); |
There was a problem hiding this comment.
Very nice refinement :-)
| private final MetricFetcher<?> metricFetcher; | ||
|
|
||
| /** | ||
| * Instantiates a new Abstract job vertex handler. |
There was a problem hiding this comment.
wrong java docs: Should be SubtaskExecutionAttemptDetailsHandler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
org.apache.flink.runtime.rest.handler.legacy.SubtaskExecutionAttemptDetailsHandlerto flip-6WebMonitorEndpoint.Brief change log
JobVertexHandlerandSubtaskAttemptHandler.SubtaskExecutionAttemptDetailsHandlerin flip-6 REST framework.JobVertexMetricsto public classIOMetricsInfo, make it more reusable.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation