[FLINK-8267] [Kinesis Connector] update Kinesis Producer example for setting Region key #5301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bowenli86 can you squash the commits into a single one, with appropriate commit message? Thanks! |
tzulitai
reviewed
Jan 22, 2018
| producerConfig.put(AWSConfigConstants.AWS_ACCESS_KEY_ID, "aws_access_key_id"); | ||
| producerConfig.put(AWSConfigConstants.AWS_SECRET_ACCESS_KEY, "aws_secret_access_key"); | ||
| producerConfig.put("Region", "us-east-1"); |
There was a problem hiding this comment.
Is the "Region" string defined in some KPL class, e.g. XXConstants?
If yes, maybe we should just demonstrate that class.
That would make it more clear that the KPL configuration keys are directly supported.
There was a problem hiding this comment.
no, KPL doesn't have such configs. KPL takes a string like 'Region' and tries to find its setter using reflection.
…setting Region key
|
Make sense. Updated the PR also squashed all commits (first time using squash!) |
|
cc @tzulitai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update doc to guide users to use KPL's native keys to set regions.
This originates from a bug that we forgot to set region keys explicitly for kinesis connector, which has been fixed. According to the previous discussion between @tzulitai and I, we want to remove AWSConfigConstants in 2.0 because it basically copies/translates config keys of KPL/KCL, which doesn't add much value.
Guide users to use KPL's native keys to set regions can be the first step that facilitates the migration.
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation
cc @tzulitai