[FLINK-8454] [flip6] Remove JobExecutionResultCache from Dispatcher #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
executionResultRetrieval
branch
2 times, most recently
from
e0085a0
to
06c2135
Compare
…ableExecutionGraph This commit changes the OnCompletionActions interface such that it accepts an ArchivedExecutionGraph instead of a plain JobResult. This allows to archive the completed ExecutionGraph for further usage in the container component of the JobMasterRunner.
GJL
approved these changes
Jan 25, 2018
| @@ -100,8 +97,6 @@ | |||
|
|
|||
| private final LeaderElectionService leaderElectionService; | |||
|
|
|||
| private final JobExecutionResultCache jobExecutionResultCache = new JobExecutionResultCache(); | |||
There was a problem hiding this comment.
JobExecutionResultCache and JobExecutionResultCacheTest should be also removed in this commit
There was a problem hiding this comment.
Forgot about this. Will remove it.
…erializableExecutionGraph
… safe Let JobMasterGateway#requestJob and DispatcherGateway#requestJob return a CompletableFuture<ArchivedExecutionGraph> instead of a CompletableFuture<AccessExecutionGraph>. In order to support the old code and the JobManagerGateway implementation we have to keep the return type in RestfulGateway. Once the old code has been removed, we should change this as well.
The ArchivedExecutionGraphStore is responsible for storing completed jobs for historic job requests (e.g. from the web ui or from the client). The store is populated by the Dispatcher once a job has terminated. The FileArchivedExecutionGraphStore implementation persists all ArchivedExecutionGraphs on disk in order to avoid OOM problems. It only keeps some of the stored graphs in memory until it reaches a configurable size. Once coming close to this size, it will evict the elements and only reload them if requested again. Additionally, the FileArchivedExecutionGraphStore defines an expiration time after which the execution graphs will be removed from disk. This prevents excessive use of disk resources.
With the introduction of the ArchivedExecutionGraphStore to the Dispatcher, it is no longer necessary to store the JobResult separately. In order to decrease complexity and state duplication, this commit removes the JobExecutionResultCache and instead uses the ArchivedExecutionGraphStore to serve completed job information. A side effect of this change is that the JobExecutionResult is now available as long as the completed Flink job is stored in the ArchivedExecutionGraphStore.
tillrohrmann
force-pushed
the
executionResultRetrieval
branch
from
06c2135
to
0e72ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
With the introduction of the SerializableExecutionGraphStore to the Dispatcher,
it is no longer necessary to store the JobResult separately. In order to
decrease complexity and state duplication, this commit removes the
JobExecutionResultCache and instead uses the SerializableExecutionGraphStore
to serve completed job information. A side effect of this change is that the
JobExecutionResult is now available as long as the completed Flink job is stored
in the SerializableExecutionGraphStore.
This PR is based on #5310.
Brief change log
JobExecutionResultCachewith information fromSerializableExecutionGraphStoreJobExecutionResultHandlerVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation