[FLINK-8515] update RocksDBMapState to replace deprecated remove() with delete() #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, LGTM. I just have the exact same change already in one sub-commit of another open PR, so this change will get in one way or the other. |
|
This change has already gotten in via another commit. @bowenli86 can you close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
RocksDBMapState is currently using
rocksdb#remove()which is deprecated. Should be replaced withrocksdb#delete()Brief change log
update RocksDBMapState to replace deprecated remove() with delete()
Verifying this change
This change is already covered by existing tests, such as
StateBackendTestBase#testMapState()Does this pull request potentially affect one of the following parts:
none
Documentation
none