[FLINK-8212] [network] Pull EnvironmentInformation out of TaskManager… #5458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rice668
force-pushed
the
flink-8212
branch
2 times, most recently
from
1e744b0
to
cb593fc
Compare
|
@tillrohrmann I updated the code. Could you take a look ? Thanks ~ |
| private static MemoryManager createMemoryManager(TaskManagerServicesConfiguration taskManagerServicesConfiguration) throws Exception { | ||
| private static MemoryManager createMemoryManager(TaskManagerServicesConfiguration taskManagerServicesConfiguration, | ||
| long freeHeapMemoryWithDefrag, | ||
| long maxJvmHeapMemory) throws Exception { |
There was a problem hiding this comment.
The convention is to break parameter lists like
public void a(
A a,
B b) {
// foobar
}
| * | ||
| * @return memory to use for network buffers (in bytes) | ||
| */ | ||
| public static long calculateNetworkBufferMemory(TaskManagerServicesConfiguration tmConfig) { | ||
| public static long calculateNetworkBufferMemory(TaskManagerServicesConfiguration tmConfig, | ||
| long maxJvmHeapMemory) { |
There was a problem hiding this comment.
Same here with the parameters
tillrohrmann
approved these changes
Feb 14, 2018
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 14, 2018
…Services This closes apache#5458.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Pull EnvironmentInformation out of TaskManagerServices
Brief change log
Add the required information to
fromConfigurationmethod inTaskManagerRunner.javaDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation