Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7658][Table API & SQL] support Collect aggregate function in Table API #5472

Closed
wants to merge 1 commit into from

Conversation

suez1224
Copy link

What is the purpose of the change

Add Collect aggregate function for Table API.

Brief change log

  • Add Collect aggregate function for Table API

Verifying this change

  • Added integration tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

Copy link
Contributor

@fhueske fhueske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @suez1224.
Looks very good. I'll address the comment about the docs and will merge the PR.

Thanks, Fabian

@@ -2885,6 +2885,17 @@ FIELD.varSamp
</td>
</tr>

<tr>
<td>
{% highlight java %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the function as well in the Scala function table.

@fhueske
Copy link
Contributor

fhueske commented Feb 14, 2018

We also have to add the function to FunctionCatalog to be able to parse it in the String-based Java Table API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants