[FLINK-8713][tests] Ensure outdated mod time is smaller than minimum #5534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, +1 |
|
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a test instability in
FileInputFormatTest.2 tests were creating an outdated
BaseFileStatisticsby using the#lastModificationTimeof a previously createdBaseFileStatisticsand decrementing it.Since these tests were using multiple files this timestamp was only guaranteed to be lower than the last modified file, as
#lastModificationTimereturns the max timestamp across all files.We now separately calculate the minimum timestamp and decrement that instead, as this is guaranteed to be lower than the the modification time of any file.
/cc @fhueske