[FLINK-8768][network] Let NettyMessageDecoder inherit from LengthFieldBasedFrameDecoder #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowojski
approved these changes
Feb 27, 2018
| * </pre> | ||
| */ | ||
| static class NettyMessageDecoder extends LengthFieldBasedFrameDecoder { | ||
| private final boolean restoreOldNettyBehaviour; |
| @@ -44,10 +44,11 @@ | |||
| */ | |||
| public class NettyMessageSerializationTest { | |||
|
|
|||
| public static final boolean RESTORE_OLD_NETTY_BEHAVIOUR = false; | |||
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759).
|
ok, done |
tillrohrmann
approved these changes
Jun 11, 2018
There was a problem hiding this comment.
Changes look good. Thanks for the contribution @NicoK and the review @pnowojski. Merging this PR.
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Jun 12, 2018
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes apache#5570.
pnowojski
pushed a commit
to dataArtisans/flink
that referenced
this pull request
Jun 29, 2018
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes apache#5570.
NicoK
pushed a commit
to dataArtisans/flink
that referenced
this pull request
Jul 9, 2018
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes apache#5570.
NicoK
pushed a commit
to dataArtisans/flink
that referenced
this pull request
Jul 9, 2018
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes apache#5570.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes apache#5570.
NicoK
pushed a commit
that referenced
this pull request
Jan 24, 2019
…dBasedFrameDecoder This replaces one additional step from the pipeline and does not only remove overhead there but also allows use to override the #extractFrame() method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there (see FLINK-8759). This closes #5570. Signed-off-by: Nico Kruber <nico@data-artisans.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Instead of being two steps in the channel pipeline,
NettyMessageDecodercould derive fromLengthFieldBasedFrameDecoderto reduce overhead and give us more control over the protocol.As a first step, we will use this to override the
#extractFrame()method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 (see FLINK-8759).Brief change log
NettyMessageDecoderinherit fromLengthFieldBasedFrameDecoder(beware that this changes the decoder from aMessageToMessageDecoderto aByteToMessageDecoderwith different cleanup invariants!)Verifying this change
This change is already covered by existing tests, such as
NettyMessageSerializationTestor other network tests using the encoding/decoding pipeline.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation