Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4387][QS][tests] don't wait and process requests at Netty servers after shutdown request #5606

Closed
wants to merge 1 commit into from

Conversation

NicoK
Copy link
Contributor

@NicoK NicoK commented Mar 1, 2018

What is the purpose of the change

There is a race condition on an assertion in Netty's event loop that may cause
tests to fail when finished early.

This was fixed in 4.0.33.Final via netty/netty#4357 but we currently still rely on Netty 4.0.27.Final, hence the bug fix for the tests where this bug can be immanent.

Brief change log

  • in QueryableState tests, do not wait for a "quiet period" for further events to arrive and process, this is not needed here and circumvents the bug

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? JavaDocs

…er shutdown request

There is a race condition on an assertion in Netty's event loop that may cause
tests to fail when finished early.

This was fixed in 4.0.33.Final, see netty/netty#4357.
@NicoK NicoK changed the title [FLINK-4387][QS] don't wait and process requests at Netty servers after shutdown request [FLINK-4387][QS][tests] don't wait and process requests at Netty servers after shutdown request Mar 1, 2018
Copy link
Contributor

@kl0u kl0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants