[FLINK-8850] [sql-client] Add support for event-time in SQL Client #5683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
Mar 14, 2018
| # 'batch' or 'streaming' execution | ||
| type: streaming | ||
| # allow 'event-time', 'ingestion-time', or only 'processing-time' in sources | ||
| time-characteristic: event-time |
There was a problem hiding this comment.
event-time or processing-time? What effect would ingestion time have?
| switch (s) { | ||
| case PropertyStrings.EXECUTION_TIME_CHARACTERISTIC_VALUE_EVENT_TIME: | ||
| return TimeCharacteristic.EventTime; | ||
| case PropertyStrings.EXECUTION_TIME_CHARACTERISTIC_VALUE_INGESTION_TIME: |
|
|
||
| public static final String EXECUTION_TIME_CHARACTERISTIC_VALUE_PROCESSING_TIME = "processing-time"; | ||
|
|
||
| public static final String EXECUTION_TIME_CHARACTERISTIC_VALUE_INGESTION_TIME = "ingestion-time"; |
|
Thanks @fhueske. Merging this... |
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2018
rmetzger
added
component=TableSQL/Client
and removed
component=API/TableSQL
component=SQL/Client
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Adds support for event-time in SQL Client. A full end-to-end test should and will follow once we support event-time in the CSVTableSourceFactory.
Brief change log
time-characteristicpropertyVerifying this change
DependencyTestextendedDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation