Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8945] [kinesis] Allow customization of KinesisProxy #5698

Closed
wants to merge 1 commit into from

Conversation

kailashhd
Copy link
Contributor

@kailashhd kailashhd commented Mar 14, 2018

What is the purpose of the change

Allow customization of KinesisProxy. In this case we want to override just the getShardList implementation to use ListShards instead of DescribeStreams.

Brief change log

  • Changed the constructor from private to protected for KinesisProxy

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
Also verified with mvn clean verify.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@kailashhd
Copy link
Contributor Author

cc @tweise

@tweise
Copy link
Contributor

tweise commented Mar 16, 2018

+1
@StephanEwen can we get this into 1.5.0 ?

@tzulitai
Copy link
Contributor

I'm curious why we don't go directly for replacing describeStreams with listShards. Are there any other concerns for this?

@StephanEwen
Copy link
Contributor

I think this trivial change can be safely merged into 1.5

@asfgit asfgit closed this in cb60fd2 Mar 16, 2018
tweise pushed a commit to lyft/flink that referenced this pull request Mar 16, 2018
@tweise
Copy link
Contributor

tweise commented Mar 16, 2018

@StephanEwen thanks for unblocking our work!

glaksh100 pushed a commit to lyft/flink that referenced this pull request Jun 6, 2018
tweise pushed a commit to tweise/flink that referenced this pull request Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants