Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-8833] [sql-client] Create a SQL Client JSON format fat-jar #5700

Closed
wants to merge 1 commit into from

Conversation

twalthr
Copy link
Contributor

@twalthr twalthr commented Mar 14, 2018

What is the purpose of the change

This adds a JSON format fat jar for the SQL Client. Actually the jar is identical to the non-shaded jar but I would still add this for consistency in order to not confuse users.

Brief change log

  • Release fat jar added

Verifying this change

Manually verified.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not documented yet

@fhueske
Copy link
Contributor

fhueske commented Mar 17, 2018

Since we are not shading anything we could also use the Maven JAR plugin:

<plugin>
        <groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-jar-plugin</artifactId>
	<version>3.0.2</version>
	<executions>
		<execution>
			<phase>package</phase>
			<goals>
				<goal>jar</goal>
			</goals>
			<configuration>
				<classifier>sql-jar</classifier>
			</configuration>
		</execution>
	</executions>
</plugin>

@twalthr
Copy link
Contributor Author

twalthr commented Mar 26, 2018

Thanks for the hint @fhueske. I will the the jar plugin and merge this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants